Thanks everyone for replying. I took apart my old comtroller, wiped out the inside and put it together again, but no luck. The broken button (X) has a weird personality. It works once, then busts, so it might be a circuitry problem.

I'll try this out on the second controller tomorrow and tell you the results...

Any other suggestions?